!test

Greptile Summary

Removed the disable_skip mechanism that allowed bypassing test skipping through the MULTIDEVICE_DISABLE_SKIP environment variable. This cleanup removes unnecessary complexity from the test framework.

• Removed disable_skip member variable from MultiDeviceTest class
• Simplified skip logic in SetUp() and Communication test to directly check communicator availability
• Cleaned up unused imports (<mutex> and testing::Contains)
• All references to disable_skip have been completely removed from the codebase

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The changes cleanly remove a deprecated testing mechanism without affecting test logic. All references are removed completely, no dangling dependencies remain, and the simplified skip logic is correct and more maintainable.
• No files require special attention

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Env as Environment Variable
    participant Test as MultiDeviceTest
    participant Comm as Communicator
    participant GTest as Google Test Framework

    Note over Env,Test: Before PR: disable_skip mechanism
    Env->>Test: MULTIDEVICE_DISABLE_SKIP env var
    Test->>Test: Constructor: disable_skip = getNvFuserEnv()
    Test->>Test: SetUp() called
    alt disable_skip is false
        Test->>Comm: is_available()?
        Comm-->>Test: false
        Test->>GTest: GTEST_SKIP()
    else disable_skip is true
        Test->>Comm: is_available()
        Comm-->>Test: false
        Note over Test: Test runs anyway (skip disabled)
    end

    Note over Env,Test: After PR: simplified skipping
    Test->>Test: SetUp() called
    Test->>Comm: is_available()?
    alt communicator not available
        Comm-->>Test: false
        Test->>GTest: GTEST_SKIP()
    else communicator available
        Comm-->>Test: true
        Note over Test: Test proceeds normally
    end

Auto-merge Status

✅ Internal CI is finished
✅ No failed checks
✅ PR is mergeable
ℹ️ PR mergeable_state: unstable

Description

• Remove disable_skip environment variable and associated logic from multi-device tests

• Simplify conditional checks by removing disable_skip conditions

• Clean up unused includes and member variables

• Minor formatting improvements and removal of unused testing imports

if (!communicator_->is_available()) {
  GTEST_SKIP() << "This test needs an available communicator.";
}

if (!communicator_->isBackendAvailable(backend)) {
  GTEST_SKIP() << "Backend not available";
}

Do you still need it?

No, it can be removed! Thanks

No, it can be removed! Thanks

Cool! Can you approve the PR then? @samnordmann

⚠️ Auto-merge failed. Please review and merge manually.

Workflow run: https://github.com/NVIDIA/Fuser/actions/runs/20725407476

cc @xwang233